Add support to Lexus is300h MY17 (AVE30R) #345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eFiniLan
commented
Sep 3, 2018
•
eFiniLan
commented
- Lateral Control works
- Longitudinal Control by stock ACC (limit to minimum speed of 46 kph), 0:343 never show up in cabana.
- LHD, camera offset best set to 0. but default value is fine.
- 26 degree mount, camera vertically inline with FRC.
- 6 min video: https://youtu.be/bt75YNQpR5o
…el-lexus-ish-ave30r
…an/openpilot into devel-lexus-ish-ave30r # Conflicts: # selfdrive/car/toyota/interface.py
rbiasini
reviewed
Sep 3, 2018
selfdrive/car/toyota/interface.py
Outdated
| @@ -140,6 +152,8 @@ def get_params(candidate, fingerprint): | |||
| ret.minEnableSpeed = -1. | |||
| elif candidate in [CAR.RAV4, CAR.COROLLA]: # TODO: hack ICE to do stop and go | |||
| ret.minEnableSpeed = 19. * CV.MPH_TO_MS | |||
| elif candidate == CAR.LEXUS_AVE30: | |||
| ret.minEnableSpeed = 46. * CV.KPH_TO_MS # MY17 is300h/AVE30R (AU ver.) does not have stop and go, minimum ACC speed allow is 46kph | |||
There was a problem hiding this comment.
@EternityLan , I would keep this 19mph like for rav4 and corolla. Even though the stock acc won't engage below 28mph/46kph, the system still respond down to 18mph/30kph.
There was a problem hiding this comment.
ah cool, will update this 👍
…el-lexus-ish-ave30r # Conflicts: # selfdrive/boardd/boardd.cc # selfdrive/car/toyota/interface.py # selfdrive/car/toyota/values.py
…el-lexus-ish-ave30r # Conflicts: # selfdrive/car/toyota/interface.py
…el-lexus-ish-ave30r
…el_lexus-ish-ave30r_v2
…an/openpilot into devel_lexus-ish-ave30r_v2
Devel lexus ish ave30r v2
…el-lexus-ish-ave30r
…el-lexus-ish-ave30r
…el-lexus-ish-ave30r
…el-lexus-ish-ave30r
…el-lexus-ish-ave30r
…el-lexus-ish-ave30r
This reverts commit b9cf00f.
…el-lexus-ish-ave30r # Conflicts: # selfdrive/car/toyota/interface.py
…vel-lexus-ish-ave30r
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.